Refactor dubbo-samples-local #763
Open
+774
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyf2016
commented
Mar 3, 2023
fyf2016
commented
- add dubbo-samples-local module refator code
|
Please add ASF license for newly added files. |
chickenlj
requested changes
Mar 6, 2023
| @@ -17,8 +17,22 @@ | |||
|
|
|||
| # local call through injvm, start test container only | |||
| services: | |||
| dubbo-samples-local-test: | |||
| local-provider: | |||
There was a problem hiding this comment.
The test failed for lacking zookeeper configuration.
|
Please read this documentation to learn about how |
|
Instead of separating provider and consumer into different modules or processes like the other samples do, we should put provider and consumer in the same process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.