Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] LeastActiveLoadBalance does not properly utilize weights. #14406

Open
4 tasks done
howie-xu opened this issue Jul 9, 2024 · 4 comments
Open
4 tasks done

[Feature] LeastActiveLoadBalance does not properly utilize weights. #14406

howie-xu opened this issue Jul 9, 2024 · 4 comments
Assignees
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@howie-xu
Copy link
Contributor

howie-xu commented Jul 9, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

In LeastActiveLoadBalance, instances are first filtered by the minimum number of active connections. If there is more than one instance with the minimum number of active connections, a random selection is made based on weights. This design seems somewhat unreasonable, and the warmup feature doesn't have much effect (a batch of instances that are restarted or scaled up will still suddenly receive a large number of requests). Could we use the weights more effectively during the minimum connection filtering phase, for example, by using active * afterWarmup to determine the least active instance?

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@howie-xu howie-xu added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Jul 9, 2024
@wcy666103
Copy link
Contributor

Please submit in English Only

@howie-xu howie-xu changed the title Version:[3.2],LeastActiveLoadBalance未合理使用权重 Version:[3.2],LeastActiveLoadBalance does not properly utilize weights. Jul 9, 2024
@howie-xu howie-xu changed the title Version:[3.2],LeastActiveLoadBalance does not properly utilize weights. [Feature] LeastActiveLoadBalance does not properly utilize weights. Jul 9, 2024
@AlbumenJ
Copy link
Member

Yes, we need a new algorithm

@howie-xu
Copy link
Contributor Author

howie-xu commented Jul 10, 2024

Can the actual number of active be directly changed to "active * afterWarmup" in the LeastActiveLoadBalance?

@AlbumenJ
Copy link
Member

Can the actual number of active be directly changed to "active * afterWarmup" in the LeastActiveLoadBalance?

This may be not well enough. In active * afterWarmup, the newly launched node will get lower score and will be more high weighed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

3 participants