Support asterisk #14409
Support asterisk #14409
Conversation
|
| @@ -483,7 +483,7 @@ public String getAnyMethodParameter(String key) { | |||
| * @return A new URLParam | |||
| */ | |||
| public URLParam addParameter(String key, String value) { | |||
| if (StringUtils.isEmpty(key) || StringUtils.isEmpty(value)) { | |||
| if (StringUtils.isEmpty(key)) { | |||
There was a problem hiding this comment.
Why change this? This may cause some usage mistakes
There was a problem hiding this comment.
When a consumer with a * version invoke a null version provider
Building a remote URL based on the consumer's URL will be contiains * version
It's not a good result and will blocked by PermittedSerializationKeeper.checkSerializationPermitted
This issue may only arise when the * symbol is used and The impact of the change will be widespread
But null valus has meanings seems makes scene and 10+ application running well when I made these changes
It's true that no one dares to say these is no other problem
I've been experimenting for over a month and haven't failed yet
There was a problem hiding this comment.
And a consumer with a * version invoke a null version provider worked well at 2.7
I use different version and condition-router to achieve gray and business group
And like to make the dubbo:consumer version = *
It's not work when I update to 3.2 or 3.3
There was a problem hiding this comment.
It would be better to change PermittedSerializationKeeper.checkSerializationPermitted in the scenarios.
There was a problem hiding this comment.
Maybe It's not just this problom
It would be better when the * version consumer called the null version provider to build the null version URL
There was a problem hiding this comment.
URL is a really really basic component for Dubbo, so I would prefer not to change it enless we have the conclusion that we can only change it to fix a issue.
I want consumer with * version to router diffrent version provider which dubbo 2.7 supported
there is two problem
1.nacos dataId not support * SYMBOL
2.consumer with * version invoke Null version provider will block by PermittedSerializationKeeper.checkSerializationPermitted
Because the provider urlParam of version built by consumer has *
Because the null value will not replace the exist urlParam