[Dubbo-889-Attachments] support implicit delivery of attachments from provider to consumer

[chickenlj]

What is the purpose of the change

Fixes #889, support implicit delivery of attachments from provider to consumer

Brief changelog

Not completely finished yet.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
• Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

[codecov-io]

Codecov Report

Merging #1442 into master will increase coverage by <.01%.
The diff coverage is 47.28%.

@@            Coverage Diff             @@
##           master    #1442      +/-   ##
==========================================
+ Coverage   31.57%   31.58%   +<.01%     
==========================================
  Files         682      682              
  Lines       33035    33099      +64     
  Branches     6592     6604      +12     
==========================================
+ Hits        10432    10454      +22     
- Misses      20750    20785      +35     
- Partials     1853     1860       +7

Impacted Files	Coverage Δ
.../main/java/com/alibaba/dubbo/common/Constants.java	88.88% <ø> (ø)	⬆️
...ba/com/caucho/hessian/io/AbstractHessianInput.java	7.69% <ø> (ø)	⬆️
...ibaba/com/caucho/hessian/io/SerializerFactory.java	61.2% <ø> (ø)	⬆️
...m/alibaba/com/caucho/hessian/io/Hessian2Input.java	17.94% <0%> (ø)	⬆️
...cluster/loadbalance/ConsistentHashLoadBalance.java	0% <0%> (ø)	⬆️
.../com/caucho/hessian/io/CollectionDeserializer.java	32.6% <0%> (ø)	⬆️
...exchange/support/header/HeaderExchangeChannel.java	12.08% <0%> (ø)	⬆️
...onfig/spring/schema/DubboBeanDefinitionParser.java	21.07% <0%> (ø)	⬆️
...a/dubbo/remoting/exchange/codec/ExchangeCodec.java	63.55% <100%> (-1.22%)	⬇️
...libaba/dubbo/rpc/filter/ConsumerContextFilter.java	84.61% <100%> (+2.79%)	⬆️
... and 21 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f22f56...7dbd92b. Read the comment docs.

[axibx]

我认为这个commit存在bug,
DubboCodec.encodeResponseData方法在执行结果编码时，不应该依赖provide的version,
我觉得应该根据client请求的version，决定是否需要返回Attachments，否则会存在兼容性问题。

[Authorlove]

thumbs up

[chickenlj]

Response res = new Response(req.getId(), req.getVersion()); Thanks for your report. Actually, the version of response comes from request, it’s a little confusing. At first, i use `attributes in RpcContext` to pass version of request, but now i think it’s ok to keep the response version synced with that of request. What do you think?

…

On 9 Mar 2018, at 6:38 PM, Codecov ***@***.***> wrote: Codecov <https://codecov.io/gh/alibaba/dubbo/pull/1442?src=pr&el=h1> Report Merging #1442 <https://codecov.io/gh/alibaba/dubbo/pull/1442?src=pr&el=desc> into master <https://codecov.io/gh/alibaba/dubbo/commit/1f22f560a44995340daa3039b29eee72a3ea504f?src=pr&el=desc> will increase coverage by <.01%. The diff coverage is 47.28%. <https://codecov.io/gh/alibaba/dubbo/pull/1442?src=pr&el=tree> @@ Coverage Diff @@ ## master #1442 +/- ## ========================================== + Coverage 31.57% 31.58% +<.01% ========================================== Files 682 682 Lines 33035 33099 +64 Branches 6592 6604 +12 ========================================== + Hits 10432 10454 +22 - Misses 20750 20785 +35 - Partials 1853 1860 +7 Impacted Files <https://codecov.io/gh/alibaba/dubbo/pull/1442?src=pr&el=tree> Coverage Δ .../main/java/com/alibaba/dubbo/common/Constants.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL0NvbnN0YW50cy5qYXZh> 88.88% <ø> (ø) ⬆️ ...ba/com/caucho/hessian/io/AbstractHessianInput.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0Fic3RyYWN0SGVzc2lhbklucHV0LmphdmE=> 7.69% <ø> (ø) ⬆️ ...ibaba/com/caucho/hessian/io/SerializerFactory.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL1NlcmlhbGl6ZXJGYWN0b3J5LmphdmE=> 61.2% <ø> (ø) ⬆️ ...m/alibaba/com/caucho/hessian/io/Hessian2Input.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==> 17.94% <0%> (ø) ⬆️ ...cluster/loadbalance/ConsistentHashLoadBalance.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL2xvYWRiYWxhbmNlL0NvbnNpc3RlbnRIYXNoTG9hZEJhbGFuY2UuamF2YQ==> 0% <0%> (ø) ⬆️ .../com/caucho/hessian/io/CollectionDeserializer.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0NvbGxlY3Rpb25EZXNlcmlhbGl6ZXIuamF2YQ==> 32.6% <0%> (ø) ⬆️ ...exchange/support/header/HeaderExchangeChannel.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2Uvc3VwcG9ydC9oZWFkZXIvSGVhZGVyRXhjaGFuZ2VDaGFubmVsLmphdmE=> 12.08% <0%> (ø) ⬆️ ...onfig/spring/schema/DubboBeanDefinitionParser.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=> 21.07% <0%> (ø) ⬆️ ...a/dubbo/remoting/exchange/codec/ExchangeCodec.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvY29kZWMvRXhjaGFuZ2VDb2RlYy5qYXZh> 63.55% <100%> (-1.22%) ⬇️ ...libaba/dubbo/rpc/filter/ConsumerContextFilter.java <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0NvbnN1bWVyQ29udGV4dEZpbHRlci5qYXZh> 84.61% <100%> (+2.79%) ⬆️ ... and 21 more <https://codecov.io/gh/alibaba/dubbo/pull/1442/diff?src=pr&el=tree-more> Continue to review full report at Codecov <https://codecov.io/gh/alibaba/dubbo/pull/1442?src=pr&el=continue>. Legend - Click here to learn more <https://docs.codecov.io/docs/codecov-delta> Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov <https://codecov.io/gh/alibaba/dubbo/pull/1442?src=pr&el=footer>. Last update 1f22f56...7dbd92b <https://codecov.io/gh/alibaba/dubbo/pull/1442?src=pr&el=lastupdated>. Read the comment docs <https://docs.codecov.io/docs/pull-request-comments>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1442 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARQliUnD-I-PhWBNrcr2Xso_Z8qxys-yks5tclu5gaJpZM4SkCUy>.

[axibx]

没毛病，是我看漏了
encodeResponseData(channel, out, res.getResult(), res.getVersion());
thumbs up

[nzomkxia]

can you commit a test case for the change?

[chickenlj]

I will resolve the conflicts, add some test cases.

[chickenlj]

Sorry, some problem with the personal remote repository, i will submit a new PR.