Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually merge the work made by pull request #1491 on master branch #1554

Merged
merged 3 commits into from
Apr 5, 2018
Merged

manually merge the work made by pull request #1491 on master branch #1554

merged 3 commits into from
Apr 5, 2018

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Apr 4, 2018

What is the purpose of the change

Update pom for into apache incubator, partial fix for this issue: https://issues.apache.org/jira/projects/DUBBO/issues/DUBBO-7?filter=allopenissues

Brief changelog

  1. update pom.xml license
  2. update scm, mailLists, issueManagement, organization
  3. add DISCLAIMER

Verifying this change

All unit tests are pass

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@diecui1202
Copy link

That's good to me. Please accept it.

@beiwei30 @chickenlj @ralf0131

@codecov-io
Copy link

Codecov Report

Merging #1554 into master will increase coverage by 0.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1554      +/-   ##
==========================================
+ Coverage   30.69%   31.61%   +0.91%     
==========================================
  Files         682      682              
  Lines       32174    33048     +874     
  Branches     6294     6597     +303     
==========================================
+ Hits         9877    10447     +570     
- Misses      20591    20742     +151     
- Partials     1706     1859     +153
Impacted Files Coverage Δ
...ava/com/alibaba/dubbo/rpc/filter/tps/StatItem.java 79.16% <0%> (-15.84%) ⬇️
...o/rpc/cluster/support/MergeableClusterInvoker.java 37.86% <0%> (-7.92%) ⬇️
.../alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java 61.9% <0%> (-6.52%) ⬇️
...alibaba/dubbo/remoting/transport/CodecSupport.java 69.23% <0%> (-4.69%) ⬇️
.../java/com/alibaba/dubbo/config/ConsumerConfig.java 53.84% <0%> (-4.49%) ⬇️
...n/java/com/alibaba/dubbo/rpc/support/RpcUtils.java 20.27% <0%> (-4.32%) ⬇️
.../rpc/cluster/router/condition/ConditionRouter.java 71.11% <0%> (-3.89%) ⬇️
...bbo/rpc/cluster/loadbalance/RandomLoadBalance.java 50% <0%> (-2.95%) ⬇️
...ba/dubbo/remoting/transport/netty/NettyClient.java 72.58% <0%> (-2.86%) ⬇️
...ba/com/caucho/hessian/io/CollectionSerializer.java 57.14% <0%> (-2.86%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab2af69...2c51d5b. Read the comment docs.

@lovepoem lovepoem merged commit 20aa3f0 into apache:master Apr 5, 2018
@beiwei30 beiwei30 deleted the dubbo-7 branch April 8, 2018 02:20
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
…anch (apache#1554)

* Manually merge pull request apache#1486, to make travis ci and codecov work after apache incubator transition.

* update pom license, scm, maillists, issuemanagement, add DISCLAIMER (apache#1491)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants