Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Locale serialize&deserialize support #1760

Closed
wants to merge 1 commit into from
Closed

add Locale serialize&deserialize support #1760

wants to merge 1 commit into from

Conversation

nzomkxia
Copy link
Member

@nzomkxia nzomkxia commented May 9, 2018

What is the purpose of the change

fix #906 and add deserialize support

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@nzomkxia nzomkxia closed this May 9, 2018
@codecov-io
Copy link

codecov-io commented May 9, 2018

Codecov Report

Merging #1760 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1760      +/-   ##
============================================
- Coverage     37.95%   37.93%   -0.03%     
+ Complexity     4026     4022       -4     
============================================
  Files           618      618              
  Lines         29728    29728              
  Branches       5242     5242              
============================================
- Hits          11283    11277       -6     
- Misses        16607    16609       +2     
- Partials       1838     1842       +4
Impacted Files Coverage Δ Complexity Δ
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...ba/dubbo/remoting/transport/netty/NettyServer.java 67.27% <0%> (-3.64%) 8% <0%> (-1%)
...baba/dubbo/remoting/transport/mina/MinaClient.java 57.81% <0%> (-1.57%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a2569...e27d8d7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON.json(Locale) throw StackOverflowError
2 participants