-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HashedWheelTimer #1973
HashedWheelTimer #1973
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1973 +/- ##
============================================
+ Coverage 50.04% 50.22% +0.17%
- Complexity 4707 4746 +39
============================================
Files 562 563 +1
Lines 25213 25506 +293
Branches 4449 4508 +59
============================================
+ Hits 12618 12810 +192
- Misses 10688 10739 +51
- Partials 1907 1957 +50
Continue to review full report at Codecov.
|
ISSUE: |
@@ -718,4 +720,16 @@ public static String toArgumentString(Object[] args) { | |||
} | |||
return buf.toString(); | |||
} | |||
|
|||
public static String simpleClassName(Class<?> clazz) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a class Named ClassUtils or use org.apache.commons.lang3.ClassUtils.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to move this into org.apache.dubbo.common.utils.ClassHelper
} | ||
String className = clazz.getName(); | ||
final int lastDotIdx = className.lastIndexOf(PACKAGE_SEPARATOR_CHAR); | ||
if (lastDotIdx > -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be a innnerClass
@carryxyh I have add some comment while I review your code. Please check it. |
@cvictory |
* * HashedWheelTimer to check timeout future * when the future is done, do not set it is timeout
HashedWheelTimer to check timeout future
The class about HashedWheelTimer is from netty which with header like :
It will decrease circulate times compared to the old way.