Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dubbo-rpc-http resouces setting name #2124

Merged
merged 2 commits into from
Aug 2, 2018

Conversation

yunxiyi
Copy link
Contributor

@yunxiyi yunxiyi commented Jul 24, 2018

What is the purpose of the change

fix dubbo-rpc-http resouces setting name

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2124 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #2124     +/-   ##
==========================================
- Coverage     54.19%   54.1%   -0.1%     
+ Complexity     5085    5079      -6     
==========================================
  Files           559     559             
  Lines         24922   24922             
  Branches       4442    4442             
==========================================
- Hits          13506   13483     -23     
- Misses         9380    9398     +18     
- Partials       2036    2041      +5
Impacted Files Coverage Δ Complexity Δ
...he/dubbo/remoting/transport/netty/NettyClient.java 72.88% <0%> (-8.48%) 12% <0%> (-1%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) 3% <0%> (ø)
...onfig/spring/extension/SpringExtensionFactory.java 78.57% <0%> (-7.15%) 10% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 77.77% <0%> (-5.56%) 5% <0%> (-1%)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.25% <0%> (-5%) 22% <0%> (-1%)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 51.89% <0%> (-3.8%) 11% <0%> (-2%)
...e/dubbo/remoting/transport/netty4/NettyServer.java 72.13% <0%> (-3.28%) 9% <0%> (-1%)
...bo/remoting/transport/netty/NettyCodecAdapter.java 53.12% <0%> (-1.57%) 3% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 57.89% <0%> (-1.06%) 18% <0%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b6e6f3...7b00d1f. Read the comment docs.

@ralf0131
Copy link
Contributor

ralf0131 commented Aug 2, 2018

LGTM, thanks for the pull request!

@ralf0131 ralf0131 merged commit c904589 into apache:master Aug 2, 2018
carryxyh pushed a commit to carryxyh/incubator-dubbo that referenced this pull request Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants