[Dubbo-issue-2184] Fix Return the hanging client requests ASAP. when connection is broken unexpectedly. #2184 #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daryl666
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
============================================
- Coverage 54.24% 54.18% -0.07%
+ Complexity 5121 5118 -3
============================================
Files 569 569
Lines 25031 25032 +1
Branches 4456 4456
============================================
- Hits 13579 13563 -16
- Misses 9415 9432 +17
Partials 2037 2037
Continue to review full report at Codecov.
|
carryxyh
reviewed
Aug 8, 2018
| @@ -70,7 +71,8 @@ public void run() { | |||
| if (lastRead != null && now - lastRead > heartbeatTimeout) { | |||
| logger.warn("Close channel " + channel | |||
| + ", because heartbeat read idle time out: " + heartbeatTimeout + "ms"); | |||
| if (channel instanceof Client) { | |||
|
|
|||
| if (channel instanceof Client && channel.getUrl().getParameter(Constants.HEARTBEAT_RECONNECT, Constants.DEFAULT_HEARTBEAT_RECONNECT)) { | |||
There was a problem hiding this comment.
This op can not make the hanging request return directly. It just control the reconnect.
I didn't think this pr can solve this problem.
Maybe u should fix or send another pr
:)
There was a problem hiding this comment.
Agree. This patch didn't solve the problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix Return the hanging client requests ASAP. when connection is broken unexpectedly. #2184
Brief changelog
add the configuration of heartbeat reconnect, default true, if set false, when heartbeat timeout, consumer disconnect
Verifying this change
org.apache.dubbo.common.Constants
org.apache.dubbo.remoting.exchange.support.header.HeartBeatTask
From Baiji, Term 268, Team 3, Issue #2184, Q3-5