Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-issue1814][ Baiji-9] Add .xml configuration of graceful close #2360

Merged
merged 2 commits into from
Aug 31, 2018

Conversation

jinzeyu0
Copy link
Contributor

What is the purpose of the change

Brief changelog

[Dubbo-1814]" add xml configuration of dubbo.service.shutdown.wait " to ensure gracefully close.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@jinzeyu0
Copy link
Contributor Author

The newest commit is the final answer

@jinzeyu0 jinzeyu0 closed this Aug 28, 2018
@jinzeyu0 jinzeyu0 changed the title Q3 Part1 [Dubbo-issue1814][ Baiji-9] 增加优雅停机的xml配置 Aug 28, 2018
@jinzeyu0 jinzeyu0 reopened this Aug 28, 2018
@jinzeyu0 jinzeyu0 changed the title [Dubbo-issue1814][ Baiji-9] 增加优雅停机的xml配置 [Dubbo-issue1814][ Baiji-9] Add .xml configuration of graceful close Aug 28, 2018
@chickenlj
Copy link
Contributor

I think there's no harm to provide an extra configuration, besides, it's more reasonable than that on <dubbo:registry />.

@chickenlj chickenlj merged commit a3e4593 into apache:master Aug 31, 2018
zzzzhougit pushed a commit to zzzzhougit/incubator-dubbo that referenced this pull request Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants