Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractRegistryFactory Unit Test: destroyAll method #2581

Merged
merged 1 commit into from
Sep 29, 2018
Merged

AbstractRegistryFactory Unit Test: destroyAll method #2581

merged 1 commit into from
Sep 29, 2018

Conversation

tswstarplanet
Copy link
Contributor

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2581 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2581   +/-   ##
=========================================
  Coverage     55.09%   55.09%           
- Complexity     5292     5293    +1     
=========================================
  Files           573      573           
  Lines         25538    25538           
  Branches       4531     4531           
=========================================
  Hits          14069    14069           
- Misses         9365     9367    +2     
+ Partials       2104     2102    -2
Impacted Files Coverage Δ Complexity Δ
...che/dubbo/remoting/transport/mina/MinaChannel.java 42.25% <0%> (-11.27%) 15% <0%> (-1%)
...onfig/spring/extension/SpringExtensionFactory.java 79.31% <0%> (-6.9%) 11% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 58.06% <0%> (-6.46%) 3% <0%> (ø)
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 83.33% <0%> (-5.56%) 6% <0%> (-1%)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-1.48%) 29% <0%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 58.33% <0%> (-0.84%) 30% <0%> (-1%)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 49.3% <0%> (-0.7%) 16% <0%> (-1%)
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 50% <0%> (+8.33%) 3% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 66.25% <0%> (+8.75%) 21% <0%> (+2%) ⬆️
...ubbo/registry/support/AbstractRegistryFactory.java 80.64% <0%> (+29.03%) 7% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be51a11...f97cbb9. Read the comment docs.

@zonghaishang zonghaishang merged commit 9b7284f into apache:master Sep 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants