Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

重构 ServiceBean 的 isDelay 方法，使其更符合语义 #2686

Merged
merged 2 commits into from
Oct 30, 2018
Merged

重构 ServiceBean 的 isDelay 方法，使其更符合语义 #2686

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ad7e7c
Refactor method isDelay of ServiceBean to fix the wrong meaning of th…
code4wt Oct 25, 2018
2f1b767
Remove unnecessary method isDelay of ServiceBean
code4wt Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions ...-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ServiceBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,23 +107,14 @@ public Service getService() {

@Override
public void onApplicationEvent(ContextRefreshedEvent event) {
if (isDelay() && !isExported() && !isUnexported()) {
if (!isExported() && !isUnexported()) {
if (logger.isInfoEnabled()) {
logger.info("The service ready on spring started. service: " + getInterface());
}
export();
}
}

private boolean isDelay() {
Integer delay = getDelay();
ProviderConfig provider = getProvider();
if (delay == null && provider != null) {
delay = provider.getDelay();
}
return supportedApplicationListener && (delay == null || delay == -1);
}

@Override
@SuppressWarnings({"unchecked", "deprecation"})
public void afterPropertiesSet() throws Exception {
Expand Down Expand Up @@ -251,7 +242,7 @@ && getInterface() != null && getInterface().length() > 0
setPath(beanName);
}
}
if (!isDelay()) {
if (!supportedApplicationListener) {
export();
}
}
Expand Down