Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize REGISTRIES field in AbstractRegistryFactory. #2703

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Optimize REGISTRIES field in AbstractRegistryFactory. #2703

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0758e8
modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的…
Oct 29, 2018
1309b11
modify ConcurrentHashMap to HashMap.这里REGISTRIES在使用的时候都会先加锁，不存在多线程安全的…
Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...registry-api/src/main/java/org/apache/dubbo/registry/support/AbstractRegistryFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused imports

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,i will remove it.but I do not know why all checks have failed.could you tell me reason? I have never used travis CI before.

import java.util.concurrent.locks.ReentrantLock;
Expand All @@ -44,7 +45,7 @@ public abstract class AbstractRegistryFactory implements RegistryFactory {
private static final ReentrantLock LOCK = new ReentrantLock();

// Registry Collection Map<RegistryAddress, Registry>
private static final Map<String, Registry> REGISTRIES = new ConcurrentHashMap<String, Registry>();
private static final Map<String, Registry> REGISTRIES = new HashMap<>();

/**
* Get all registries
Expand Down