Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log4j pattern layout #2802

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Fix log4j pattern layout #2802

merged 1 commit into from
Dec 6, 2018

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Nov 19, 2018

What is the purpose of the change

Fix log4j pattern layout

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2802 into master will increase coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2802     +/-   ##
========================================
+ Coverage   62.49%   63.5%     +1%     
========================================
  Files         599     577     -22     
  Lines       27918   25929   -1989     
  Branches     4829    4541    -288     
========================================
- Hits        17447   16465    -982     
+ Misses       8210    7309    -901     
+ Partials     2261    2155    -106
Impacted Files Coverage Δ
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-13.89%) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 39.47% <0%> (-10.53%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-8.7%) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 78.94% <0%> (-5.27%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 81.25% <0%> (-1.93%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.22% <0%> (-1.87%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 57.89% <0%> (-1.06%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9466425...85db708. Read the comment docs.

@ralf0131
Copy link
Contributor

ralf0131 commented Dec 6, 2018

Looks good to me!
I'll be appreciated if you can change the date format from dd/MM/yy to yyyy-MM-dd or dd/MM/yyyy, which is easier to read.
I will merge this pull request anyway.

@ralf0131 ralf0131 merged commit 216e750 into apache:master Dec 6, 2018
@lonre lonre deleted the patch branch December 7, 2018 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants