Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the times of registry retry. #2946

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

carryxyh
Copy link
Member

The default value is 3.
Limiting the number of retries prevents memory leaks in some extreme cases.

The default value is 3.
@codecov-io
Copy link

Codecov Report

Merging #2946 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2946      +/-   ##
=========================================
+ Coverage   63.99%     64%   +0.01%     
=========================================
  Files         584     584              
  Lines       26050   26056       +6     
  Branches     4562    4563       +1     
=========================================
+ Hits        16671   16678       +7     
+ Misses       7200    7198       -2     
- Partials     2179    2180       +1
Impacted Files Coverage Δ
...c/main/java/org/apache/dubbo/common/Constants.java 88.88% <ø> (ø) ⬆️
...apache/dubbo/registry/retry/AbstractRetryTask.java 58.33% <50%> (-1.67%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 73.58% <0%> (-7.55%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.73%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 69.79% <0%> (-1.35%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.2% <0%> (+1.12%) ⬆️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 62.36% <0%> (+1.74%) ⬆️
...he/dubbo/remoting/transport/netty/NettyServer.java 71.42% <0%> (+3.57%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227a169...d88584c. Read the comment docs.

@beiwei30 beiwei30 merged commit afcb9f2 into apache:master Dec 13, 2018
@carryxyh carryxyh deleted the feature-retry-times branch December 13, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants