-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance ConsistentHashLoadBalance ut #2947
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
+ Coverage 63.91% 64.17% +0.25%
==========================================
Files 584 584
Lines 26056 26056
Branches 4563 4563
==========================================
+ Hits 16654 16721 +67
+ Misses 7224 7155 -69
- Partials 2178 2180 +2
Continue to review full report at Codecov.
|
@lixiaojiee |
I think in this PR you are fixing the null pointer exception issue while calling getArgument of mocked invocation object in UT, because it was not mocked. Is this understanding of mine is correct? |
...er/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalanceTest.java
Outdated
Show resolved
Hide resolved
...er/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalanceTest.java
Outdated
Show resolved
Hide resolved
@khanimteyaz There are two reasons why I changed this ut: |
What is the purpose of the change
enhance ConsistentHashLoadBalance ut
Brief changelog
/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/ConsistentHashLoadBalanceTest.java
/dubbo-cluster/src/test/java/org/apache/dubbo/rpc/cluster/loadbalance/LoadBalanceBaseTest.java
Verifying this change
ut pass
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.