Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue-2948:spring boot external config invalid #2950

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

meiping05
Copy link
Contributor

Environment

  • Dubbo version: 2.6.0
  • Operating System version: Red Hat Enterprise Linux Server release 6.3
  • Java version: 1.8.0_92

Steps to reproduce this issue

Spring Boot使用外部配置文件,没有起作用,还是使用的包内application.properties

@codecov-io
Copy link

Codecov Report

Merging #2950 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2950      +/-   ##
==========================================
- Coverage   64.04%   63.98%   -0.06%     
==========================================
  Files         584      584              
  Lines       26050    26050              
  Branches     4562     4562              
==========================================
- Hits        16683    16668      -15     
- Misses       7190     7208      +18     
+ Partials     2177     2174       -3
Impacted Files Coverage Δ
...dubbo/config/spring/util/PropertySourcesUtils.java 85.71% <100%> (ø) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 67.78% <0%> (-3.36%) ⬇️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 77.2% <0%> (-2.21%) ⬇️
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 70.17% <0%> (-1.76%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.73%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 65.83% <0%> (-0.84%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.2% <0%> (-0.76%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 55.68% <0%> (-0.38%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227a169...8c3c885. Read the comment docs.

@beiwei30 beiwei30 merged commit b8c3e84 into apache:master Dec 13, 2018
@meiping05 meiping05 deleted the fix-issue-2949 branch December 15, 2018 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants