Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestProtocol will be failed to export. #2965

Merged
merged 2 commits into from
Dec 14, 2018
Merged

Conversation

Jeff-Lv
Copy link
Contributor

@Jeff-Lv Jeff-Lv commented Dec 14, 2018

What is the purpose of the change

ProviderModel must be init before doExportUrls to fix the REST protocol issue.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f5be817). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2965   +/-   ##
========================================
  Coverage          ?     64%           
========================================
  Files             ?     584           
  Lines             ?   26059           
  Branches          ?    4562           
========================================
  Hits              ?   16678           
  Misses            ?    7203           
  Partials          ?    2178
Impacted Files Coverage Δ
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 78.12% <ø> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 54.31% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5be817...6594dc2. Read the comment docs.

@beiwei30 beiwei30 merged commit 31de870 into apache:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants