Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize the ReferenceConfig logic #2976

Merged
merged 1 commit into from
Dec 17, 2018
Merged

optimize the ReferenceConfig logic #2976

merged 1 commit into from
Dec 17, 2018

Conversation

lixiaojiee
Copy link
Contributor

What is the purpose of the change

extract the resolve file logic

Brief changelog

/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java

Verifying this change

ut passed

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #2976 into master will decrease coverage by 0.19%.
The diff coverage is 20.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2976     +/-   ##
=========================================
- Coverage   64.08%   63.89%   -0.2%     
=========================================
  Files         584      584             
  Lines       26059    26061      +2     
  Branches     4562     4562             
=========================================
- Hits        16700    16651     -49     
- Misses       7184     7226     +42     
- Partials     2175     2184      +9
Impacted Files Coverage Δ
.../java/org/apache/dubbo/config/ReferenceConfig.java 56.01% <20.68%> (-0.05%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-13.89%) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) ⬇️
...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java 41.66% <0%> (-8.34%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-4.35%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 67.85% <0%> (-3.58%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 62.9% <0%> (-3.23%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31de870...b34494c. Read the comment docs.

@beiwei30 beiwei30 merged commit 99632b3 into apache:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants