fix #3124 . move RegistryDataConfig configuration into RegistryConfig… #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Config and remove RegistryDataConfig
Codecov Report
@@ Coverage Diff @@
## 2.7.0-release #3129 +/- ##
===================================================
+ Coverage 62.53% 63.68% +1.14%
Complexity 75 75
===================================================
Files 674 651 -23
Lines 30172 28150 -2022
Branches 5070 4774 -296
===================================================
- Hits 18868 17926 -942
+ Misses 8940 7981 -959
+ Partials 2364 2243 -121
Continue to review full report at Codecov.
|
khanimteyaz
reviewed
Jan 3, 2019
| String[] paramsToRegistry = getParamsToRegistry(DEFAULT_REGISTER_CONSUMER_KEYS, | ||
| registryUrl.getParameter(EXTRA_CONSUMER_CONFIG_KEYS_KEY, new String[0])); | ||
| return URL.valueOf(consumerUrl, paramsToRegistry, null).addParameters( | ||
| return URL.valueOf(consumerUrl, DEFAULT_REGISTER_CONSUMER_KEYS, null).addParameters( |
There was a problem hiding this comment.
@cvictory would it be possible to bit explain it bit here, what we are doing here?
There was a problem hiding this comment.
@khanimteyaz in 2.7.0 we hope to simplify URL put into the registry center.
beiwei30
reviewed
Jan 4, 2019
| * @since 2.7.0 | ||
| */ | ||
| public static final String SIMPLE_CONSUMER_CONFIG_KEY = "simple.consumer.config"; | ||
| public static final String SIMPLIFIED_KEY = "simplified"; |
There was a problem hiding this comment.
in the future, we should categorize such constants into groups, for this case, it'd be better and more clear if we move it into RegistryConstants. @cvictory, would you mind to file one issue against this suggestion?
This was referenced Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3124