Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prefix, use hypher case instead of camel case #3143

Merged
merged 1 commit into from
Jan 6, 2019
Merged

fix prefix, use hypher case instead of camel case #3143

merged 1 commit into from
Jan 6, 2019

Conversation

beiwei30
Copy link
Member

@beiwei30 beiwei30 commented Jan 4, 2019

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3143 into 2.7.0-release will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.0-release    #3143      +/-   ##
===================================================
+ Coverage            63.57%   63.63%   +0.06%     
  Complexity              75       75              
===================================================
  Files                  651      651              
  Lines                28154    28154              
  Branches              4774     4774              
===================================================
+ Hits                 17898    17917      +19     
+ Misses                8008     7987      -21     
- Partials              2248     2250       +2
Impacted Files Coverage Δ Complexity Δ
...n/java/org/apache/dubbo/config/AbstractConfig.java 80.13% <100%> (ø) 0 <0> (ø) ⬇️
...in/java/org/apache/dubbo/config/ServiceConfig.java 53.64% <100%> (ø) 0 <0> (ø) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 68.13% <0%> (-2.2%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 81.2% <0%> (-0.76%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 71.81% <0%> (+0.67%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (+3.52%) 0% <0%> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 85.36% <0%> (+7.31%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 0% <0%> (ø) ⬇️
...ache/dubbo/remoting/transport/AbstractChannel.java 87.5% <0%> (+12.5%) 0% <0%> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 82.05% <0%> (+17.94%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de76413...3b54ad5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants