Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata report configuration error #3183

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Fix metadata report configuration error #3183

merged 2 commits into from
Jan 11, 2019

Conversation

foreveryang321
Copy link
Contributor

What is the purpose of the change

Fix metadata report configuration error

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #3183 into 2.7.0-release will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             2.7.0-release    #3183      +/-   ##
===================================================
- Coverage            63.83%   63.76%   -0.07%     
  Complexity              75       75              
===================================================
  Files                  651      651              
  Lines                28317    28317              
  Branches              4793     4793              
===================================================
- Hits                 18076    18057      -19     
- Misses                7973     7992      +19     
  Partials              2268     2268
Impacted Files Coverage Δ Complexity Δ
.../org/apache/dubbo/config/MetadataReportConfig.java 41.66% <ø> (ø) 0 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 62.9% <0%> (-3.23%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 44.79% <0%> (-3.13%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 70.46% <0%> (-2.69%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 87.85% <0%> (-1.87%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 63.79% <0%> (-1.73%) 0% <0%> (ø)
...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java 72.5% <0%> (-1.67%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.19% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747b804...ec9ed65. Read the comment docs.

Copy link
Contributor

@khanimteyaz khanimteyaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beiwei30
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants