Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3342]fixdubbo2.7.0 com.alibaba.com.caucho.hessian.io.HessianProtocolException: 'com.alibaba.dubbo.common.URL' could not be instantiated#3342 #3345

Closed

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

fix #3342

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3345 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3345      +/-   ##
============================================
+ Coverage     63.69%   63.74%   +0.04%     
  Complexity       71       71              
============================================
  Files           661      661              
  Lines         28617    28619       +2     
  Branches       4825     4825              
============================================
+ Hits          18229    18243      +14     
+ Misses         8170     8159      -11     
+ Partials       2218     2217       -1
Impacted Files Coverage Δ Complexity Δ
...le/src/main/java/com/alibaba/dubbo/common/URL.java 9.27% <0%> (-0.13%) 0 <0> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-8.7%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.17% <0%> (-4.71%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 56.45% <0%> (-0.37%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 58.18% <0%> (+0.34%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 70.94% <0%> (+1.35%) 0% <0%> (ø) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (+1.86%) 0% <0%> (ø) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 66.12% <0%> (+3.22%) 0% <0%> (ø) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8bb74...c7d5d77. Read the comment docs.

@carryxyh
Copy link
Member

duplicate with #3350
A protected constructor is better.

@carryxyh carryxyh closed this Jan 25, 2019
@CrazyHZM CrazyHZM deleted the fixNoArgumentConstructorMethod branch January 29, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants