-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add socks5 proxy support #3624
add socks5 proxy support #3624
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3624 +/- ##
============================================
- Coverage 63.77% 63.69% -0.08%
Complexity 71 71
============================================
Files 712 713 +1
Lines 31450 31495 +45
Branches 5073 5076 +3
============================================
+ Hits 20057 20061 +4
- Misses 9103 9138 +35
- Partials 2290 2296 +6
Continue to review full report at Codecov.
|
just wondering what's situation we need use socket proxy? if it's common usage, do we need apply similar change to other remoting module? |
...bo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyClient.java
Outdated
Show resolved
Hide resolved
Please check the way to get SOCKS_PROXY_PORT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the way to get SOCKS_PROXY_PORT
@zonghaishang replace System.getProperty to ConfigUtils.getProperty. please review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
add socks5 proxy support for dubbo-remoting-netty4.
Brief changelog
Check the system property 'socks5ProxyHost' in org.apache.dubbo.remoting.transport.netty4.NettyClient#initChannel, if it exists, use the system property socks5ProxyHost and socks5ProxyPort to create a Socks5ProxyHandler and add it to the first location of the ChannelPipeline
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.