Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3746] Bugfix: infinite loop in AbstractRegistry when IOException. fix #3746 #3748

Merged
merged 3 commits into from
Apr 17, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,10 @@ public void doSaveProperties(long version) {
}
}
} catch (Throwable e) {
if (e instanceof IOException) { // may not be recoverable when IOException throws, give up retrying
kezhenxu94 marked this conversation as resolved.
Show resolved Hide resolved
logger.warn("Failed to save registry cache file, cause: " + e.getMessage(), e);
return;
}
if (version < lastCacheChanged.get()) {
return;
} else {
Expand Down