-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename ClassHelper to ClassUtils, add MethodUtils #3806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions:
- Why do we need such a change?
- What is the difference between org.apache.dubbo.common.compiler.support.ClassUtils and org.apache.dubbo.common.utils.ClassUtils?
|
If they are duplicated, I think it is better to merge them. How do you think? Are you planning to do it next, or in this pull request? |
All the UT are failing, could you please check about that? |
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Codecov Report
@@ Coverage Diff @@
## master #3806 +/- ##
============================================
- Coverage 63.97% 63.92% -0.06%
Complexity 98 98
============================================
Files 713 715 +2
Lines 31481 31497 +16
Branches 5076 5076
============================================
- Hits 20139 20133 -6
- Misses 9038 9057 +19
- Partials 2304 2307 +3
Continue to review full report at Codecov.
|
Sorry for late ,I have fixed it . |
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ReferenceConfig.java
@ralf0131 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the pull request.
What is the purpose of the change
rename ClassHelper to ClassUtils
Brief changelog
Next step :
Merging
org.apache.dubbo.common.compiler.support.ClassUtils,
org.apache.dubbo.config.spring.util.ClassUtils,
org.apache.dubbo.metadata.definition.util.ClassUtils,
Verifying this change
UT
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.