Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3817]Support Redis cluster in Metadata Report #3863

Merged
merged 8 commits into from
May 22, 2019

Conversation

cvictory
Copy link
Contributor

What is the purpose of the change

Fix #3817, for suport redis cluster in meatadata report.

Brief changelog

Introduce Redis Cluster.

Reference:

https://redis.io/topics/cluster-spec

https://redis.io/topics/cluster-tutorial

https://github.com/xetorthio/jedis#jedis-cluster

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@cvictory
Copy link
Contributor Author

I donot find how to start redis cluster in embed redis.

I will try my best to add some test.

@cvictory cvictory requested a review from chickenlj April 12, 2019 06:14
@codecov-io
Copy link

codecov-io commented Apr 12, 2019

Codecov Report

Merging #3863 into master will increase coverage by 0.01%.
The diff coverage is 21.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3863      +/-   ##
============================================
+ Coverage     62.91%   62.92%   +0.01%     
- Complexity      543      545       +2     
============================================
  Files           756      756              
  Lines         32578    32602      +24     
  Branches       5163     5166       +3     
============================================
+ Hits          20496    20516      +20     
- Misses         9718     9721       +3     
- Partials       2364     2365       +1
Impacted Files Coverage Δ Complexity Δ
.../dubbo/metadata/identifier/MetadataIdentifier.java 60.46% <ø> (ø) 0 <0> (ø) ⬇️
...ubbo/metadata/store/redis/RedisMetadataReport.java 52.94% <20%> (-47.06%) 6 <1> (+1)
.../org/apache/dubbo/config/MetadataReportConfig.java 88.09% <33.33%> (-4.22%) 0 <0> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
...stry/integration/AbstractConfiguratorListener.java 27.58% <0%> (-3.19%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.46% <0%> (-1.37%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 69.23% <0%> (-0.46%) 0% <0%> (ø)
...c/protocol/dubbo/ReferenceCountExchangeClient.java 68.51% <0%> (ø) 0% <0%> (ø) ⬇️
...rg/apache/dubbo/rpc/protocol/rest/NettyServer.java 88.23% <0%> (ø) 0% <0%> (ø) ⬇️
...rc/main/java/org/apache/dubbo/remoting/Codec2.java 100% <0%> (ø) 0% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e595e...e4ee711. Read the comment docs.

@ralf0131
Copy link
Contributor

Hi, sorry but could you resolve the conflict first?

@ralf0131 ralf0131 added the status/waiting-for-feedback Need reporters to triage label Apr 26, 2019
@cvictory cvictory added this to the 2.7.2 milestone May 5, 2019
@cvictory cvictory self-assigned this May 6, 2019
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis 元数据中心,目前不支持集群?
4 participants