-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3817]Support Redis cluster in Metadata Report #3863
Conversation
…boMetadataReportRetryTimer in MetadataReportRetry
I donot find how to start redis cluster in embed redis. I will try my best to add some test. |
Codecov Report
@@ Coverage Diff @@
## master #3863 +/- ##
============================================
+ Coverage 62.91% 62.92% +0.01%
- Complexity 543 545 +2
============================================
Files 756 756
Lines 32578 32602 +24
Branches 5163 5166 +3
============================================
+ Hits 20496 20516 +20
- Misses 9718 9721 +3
- Partials 2364 2365 +1
Continue to review full report at Codecov.
|
Hi, sorry but could you resolve the conflict first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Fix #3817, for suport redis cluster in meatadata report.
Brief changelog
Introduce Redis Cluster.
Reference:
https://redis.io/topics/cluster-spec
https://redis.io/topics/cluster-tutorial
https://github.com/xetorthio/jedis#jedis-cluster
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.