Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some variables to avoid possible confusion between Result and AppResponse. #3889

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

Rename some variables to avoid possible confusion between Result and AppResponse.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj requested a review from carryxyh April 18, 2019 12:02
@codecov-io
Copy link

Codecov Report

Merging #3889 into 3.x-dev will increase coverage by 0.09%.
The diff coverage is 58.82%.

Impacted file tree graph

@@              Coverage Diff              @@
##             3.x-dev    #3889      +/-   ##
=============================================
+ Coverage      63.62%   63.71%   +0.09%     
  Complexity        71       71              
=============================================
  Files            706      706              
  Lines          31072    31072              
  Branches        5029     5029              
=============================================
+ Hits           19769    19797      +28     
+ Misses          9023     8998      -25     
+ Partials        2280     2277       -3
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/rpc/filter/TimeoutFilter.java 66.66% <ø> (ø) 0 <0> (ø) ⬇️
...bo/rpc/cluster/support/FailsafeClusterInvoker.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/ActiveLimitFilter.java 95.45% <ø> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 76.19% <ø> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/rpc/filter/ConsumerContextFilter.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/ContextFilter.java 91.17% <100%> (ø) 0 <0> (ø) ⬇️
...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java 56.16% <33.33%> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/GenericImplFilter.java 56.38% <62.5%> (ø) 0 <0> (ø) ⬇️
.../org/apache/dubbo/rpc/filter/CompatibleFilter.java 60% <66.66%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/rpc/filter/ExceptionFilter.java 60.52% <66.66%> (ø) 0 <0> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26604f...394753e. Read the comment docs.

Copy link
Member

@carryxyh carryxyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
It seems to be clear that the Result of the call back is actually an appresponse.

If it is not for compatibility reasons, I agree to remove the Result interface of the appResponse.

@carryxyh carryxyh merged commit 13c1571 into apache:3.x-dev Apr 19, 2019
chickenlj added a commit to chickenlj/incubator-dubbo that referenced this pull request May 8, 2019
…AppResponse. (apache#3889)

Clear that the `Result` of the call back is actually an `AppResponse`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants