-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in dubbo #3937
fix typo in dubbo #3937
Conversation
Still many typos to be fixed, hang on merge. |
Codecov Report
@@ Coverage Diff @@
## master #3937 +/- ##
===========================================
+ Coverage 63.66% 64% +0.34%
Complexity 71 71
===========================================
Files 713 713
Lines 31460 32006 +546
Branches 5070 5256 +186
===========================================
+ Hits 20028 20485 +457
- Misses 9138 9195 +57
- Partials 2294 2326 +32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will merge it when I pass ci. |
What is the purpose of the change
fix #3933
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.