Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3653] Enable etcd to support metadata center #3943

Merged
merged 6 commits into from
May 5, 2019

Conversation

ralf0131
Copy link
Contributor

What is the purpose of the change

#3653 Support etcd as metadata center

Brief changelog

  • Support etcd as metadata center
  • Add unit test

Verifying this change

  • Local test passed

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@ralf0131 ralf0131 requested a review from cvictory April 28, 2019 08:47
@codecov-io
Copy link

Codecov Report

Merging #3943 into master will increase coverage by 0.5%.
The diff coverage is 74.19%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #3943     +/-   ##
===========================================
+ Coverage     63.71%   64.22%   +0.5%     
- Complexity       71       98     +27     
===========================================
  Files           713      715      +2     
  Lines         31471    31494     +23     
  Branches       5075     5077      +2     
===========================================
+ Hits          20053    20226    +173     
+ Misses         9125     8940    -185     
- Partials       2293     2328     +35
Impacted Files Coverage Δ Complexity Δ
...bo/metadata/store/consul/ConsulMetadataReport.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/metadata/support/AbstractMetadataReport.java 71.09% <100%> (-0.66%) 0 <0> (ø)
...adata/store/zookeeper/ZookeeperMetadataReport.java 75% <100%> (+0.92%) 0 <0> (ø) ⬇️
...metadata/store/etcd/EtcdMetadataReportFactory.java 100% <100%> (ø) 0 <0> (?)
...ubbo/metadata/store/redis/RedisMetadataReport.java 100% <100%> (ø) 0 <0> (ø) ⬇️
.../dubbo/metadata/identifier/MetadataIdentifier.java 60.46% <100%> (ø) 0 <0> (ø) ⬇️
.../dubbo/metadata/store/etcd/EtcdMetadataReport.java 68.18% <68.18%> (ø) 0 <0> (?)
...apache/dubbo/common/config/ConfigurationUtils.java 64% <0%> (-8%) 0% <0%> (ø)
...ava/org/apache/dubbo/config/DubboShutdownHook.java 75% <0%> (-6.25%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa8332...9929b4a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants