-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed provider set delay NullPointerException #3957
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3957 +/- ##
===========================================
- Coverage 63.97% 63.9% -0.07%
Complexity 98 98
===========================================
Files 713 713
Lines 31481 31482 +1
Branches 5076 5076
===========================================
- Hits 20139 20118 -21
- Misses 9038 9055 +17
- Partials 2304 2309 +5
Continue to review full report at Codecov.
|
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Show resolved
Hide resolved
LGTM. I will follow up to make it better, since I also need to take care shouldExport too. Thanks. |
This change does not look good to me. Why it is getting merged? |
@ralf0131 @Leishunyu pls. review #3959 |
The pull request looks good to me. |
What is the purpose of the change
#3952
fixed this bug
Brief changelog
provider's delay has not set in serviceconfig
Verifying this change
set provider's delay in serviceconfig
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.