Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed provider set delay NullPointerException #3957

Merged
merged 3 commits into from
Apr 30, 2019
Merged

fixed provider set delay NullPointerException #3957

merged 3 commits into from
Apr 30, 2019

Conversation

Leishunyu
Copy link
Contributor

What is the purpose of the change

#3952

fixed this bug

Brief changelog

provider's delay has not set in serviceconfig

Verifying this change

set provider's delay in serviceconfig

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3957 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3957      +/-   ##
===========================================
- Coverage     63.97%   63.9%   -0.07%     
  Complexity       98      98              
===========================================
  Files           713     713              
  Lines         31481   31482       +1     
  Branches       5076    5076              
===========================================
- Hits          20139   20118      -21     
- Misses         9038    9055      +17     
- Partials       2304    2309       +5
Impacted Files Coverage Δ Complexity Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 58.17% <100%> (+0.08%) 0 <0> (ø) ⬇️
.../apache/dubbo/qos/protocol/QosProtocolWrapper.java 64.1% <0%> (-17.95%) 0% <0%> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 61.4% <0%> (-7.02%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 79.69% <0%> (-1.92%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (-1.32%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 73.46% <0%> (ø) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 71.73% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54633e...29004b1. Read the comment docs.

@beiwei30
Copy link
Member

LGTM. I will follow up to make it better, since I also need to take care shouldExport too. Thanks.

@beiwei30 beiwei30 dismissed ralf0131’s stale review April 30, 2019 07:52

the change looks good enough.

@beiwei30 beiwei30 merged commit e2f3346 into apache:master Apr 30, 2019
@ralf0131
Copy link
Contributor

LGTM. I will follow up to make it better, since I also need to take care shouldExport too. Thanks.

This change does not look good to me. Why it is getting merged?
How would you planning to improve it?

@beiwei30
Copy link
Member

@ralf0131 @Leishunyu pls. review #3959

@ralf0131
Copy link
Contributor

The pull request looks good to me.
IMO, it would be better to let @Leishunyu to improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants