Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: Seperate Constants.java into some SubConstants Class - step 1 #4017

Merged
merged 4 commits into from
May 10, 2019
Merged

[DUBBO-3137]: Seperate Constants.java into some SubConstants Class - step 1 #4017

merged 4 commits into from
May 10, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue #3137: step 1

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from CrazyHZM May 10, 2019 03:17
@codecov-io
Copy link

Codecov Report

Merging #4017 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4017      +/-   ##
============================================
- Coverage     63.47%   63.46%   -0.02%     
+ Complexity      565      564       -1     
============================================
  Files           750      751       +1     
  Lines         32415    32412       -3     
  Branches       5145     5145              
============================================
- Hits          20577    20569       -8     
- Misses         9480     9486       +6     
+ Partials       2358     2357       -1
Impacted Files Coverage Δ Complexity Δ
...cluster/loadbalance/ConsistentHashLoadBalance.java 87.75% <ø> (ø) 0 <0> (ø) ⬇️
...dubbo/serialize/hessian/Hessian2Serialization.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../serialize/protostuff/ProtostuffSerialization.java 60% <0%> (ø) 0 <0> (ø) ⬇️
...protobuf/support/GenericProtobufSerialization.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/remoting/transport/CodecSupport.java 77.77% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/common/serialize/kryo/KryoSerialization.java 60% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/common/serialize/java/JavaSerialization.java 80% <100%> (ø) 0 <0> (ø) ⬇️
...e/dubbo/registry/integration/RegistryProtocol.java 82.55% <100%> (ø) 0 <0> (ø) ⬇️
...mmon/serialize/hessian2/Hessian2Serialization.java 80% <100%> (ø) 0 <0> (ø) ⬇️
.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java 9.25% <100%> (ø) 0 <0> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95e29a...97c62eb. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comment

@chickenlj chickenlj added this to the 2.7.2 milestone May 10, 2019
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit 30c3c2f into apache:master May 10, 2019
@beiwei30 beiwei30 deleted the issue3137 branch May 10, 2019 06:40
@caojiele caojiele mentioned this pull request May 10, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants