-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUBBO-3137]: Seperate Constants.java into some SubConstants Class - step 1 #4017
Conversation
...ation/dubbo-serialization-api/src/main/java/org/apache/dubbo/common/serialize/Constants.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4017 +/- ##
============================================
- Coverage 63.47% 63.46% -0.02%
+ Complexity 565 564 -1
============================================
Files 750 751 +1
Lines 32415 32412 -3
Branches 5145 5145
============================================
- Hits 20577 20569 -8
- Misses 9480 9486 +6
+ Partials 2358 2357 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at my comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
issue #3137: step 1
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.