Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUBBO-3137]: step3 - start using CommonConstants #4030

Merged
merged 11 commits into from
May 12, 2019
Merged

[DUBBO-3137]: step3 - start using CommonConstants #4030

merged 11 commits into from
May 12, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

issue #3137: start to use org.apache.dubbo.common.constants.CommonConstants

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #4030 into master will increase coverage by 0.01%.
The diff coverage is 64.34%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4030      +/-   ##
============================================
+ Coverage     63.42%   63.44%   +0.01%     
  Complexity      565      565              
============================================
  Files           755      754       -1     
  Lines         32423    32417       -6     
  Branches       5143     5143              
============================================
+ Hits          20565    20567       +2     
+ Misses         9500     9489      -11     
- Partials       2358     2361       +3
Impacted Files Coverage Δ Complexity Δ
.../factory/annotation/AnnotationBeanNameBuilder.java 96.96% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/rpc/filter/EchoFilter.java 75% <ø> (ø) 0 <0> (ø) ⬇️
...apache/dubbo/rpc/filter/ConsumerContextFilter.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...gcenter/support/etcd/EtcdDynamicConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/config/context/ConfigManager.java 66.66% <ø> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/config/ApplicationConfig.java 97.59% <ø> (ø) 0 <0> (ø) ⬇️
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 50% <ø> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/GenericImplFilter.java 53.01% <ø> (ø) 0 <0> (ø) ⬇️
...c/main/java/org/apache/dubbo/common/Constants.java 83.33% <ø> (-7.58%) 0 <0> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 59.6% <ø> (ø) 27 <0> (ø) ⬇️
... and 145 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3f4c7...7ce1741. Read the comment docs.

@beiwei30 beiwei30 requested a review from CrazyHZM May 11, 2019 15:29
Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comment.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit fe3d345 into apache:master May 12, 2019
@beiwei30 beiwei30 deleted the issue3137-merge branch May 13, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants