-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple registry #3932 #4066
Multiple registry #3932 #4066
Conversation
…boMetadataReportRetryTimer in MetadataReportRetry
…ple_registry_3932
…ple_registry_3932
…ple_registry_3932
...ltiple/src/main/java/org/apache/dubbo/registry/multiple/AbstractDynamicMultipleRegistry.java
Outdated
Show resolved
Hide resolved
...ltiple/src/main/java/org/apache/dubbo/registry/multiple/AbstractDynamicMultipleRegistry.java
Outdated
Show resolved
Hide resolved
...bbo-registry-multiple/src/main/java/org/apache/dubbo/registry/multiple/MultipleRegistry.java
Outdated
Show resolved
Hide resolved
cc2e24b
to
b95a55a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4066 +/- ##
============================================
+ Coverage 62.75% 62.91% +0.16%
- Complexity 475 504 +29
============================================
Files 766 768 +2
Lines 32899 33052 +153
Branches 5190 5219 +29
============================================
+ Hits 20647 20796 +149
+ Misses 9862 9853 -9
- Partials 2390 2403 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think this feature can work, but we need to add some docs on how to use it and tuning the performance later
What is the purpose of the change
support ##3932
Brief changelog
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.