Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple registry #3932 #4066

Merged
merged 22 commits into from
May 24, 2019
Merged

Conversation

cvictory
Copy link
Contributor

What is the purpose of the change

support ##3932

Brief changelog

  • Add multiple registry module and MultipleRegistry
  • Add Dynamic Refresh Abstract Class

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@cvictory cvictory requested a review from chickenlj May 15, 2019 10:15
@chickenlj
Copy link
Contributor

#3599
#3084

@codecov-io
Copy link

codecov-io commented May 24, 2019

Codecov Report

Merging #4066 into master will increase coverage by 0.16%.
The diff coverage is 63.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4066      +/-   ##
============================================
+ Coverage     62.75%   62.91%   +0.16%     
- Complexity      475      504      +29     
============================================
  Files           766      768       +2     
  Lines         32899    33052     +153     
  Branches       5190     5219      +29     
============================================
+ Hits          20647    20796     +149     
+ Misses         9862     9853       -9     
- Partials       2390     2403      +13
Impacted Files Coverage Δ Complexity Δ
...bbo/registry/multiple/MultipleRegistryFactory.java 100% <100%> (ø) 2 <2> (?)
...ache/dubbo/registry/multiple/MultipleRegistry.java 62.67% <62.67%> (ø) 20 <20> (?)
...ava/org/apache/dubbo/config/ApplicationConfig.java 91.3% <0%> (-6.29%) 0% <0%> (ø)
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.48% <0%> (-0.37%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
.../main/java/org/apache/dubbo/common/URLBuilder.java 59.21% <0%> (+1.31%) 0% <0%> (ø) ⬇️
...dubbo/metadata/support/AbstractMetadataReport.java 72.83% <0%> (+1.73%) 0% <0%> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb990f...28a85db. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think this feature can work, but we need to add some docs on how to use it and tuning the performance later

@chickenlj chickenlj merged commit 543a52a into apache:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants