Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance tuning for TimeoutTask in DefaultFuture #4129

Merged
merged 6 commits into from
May 23, 2019
Merged

Performance tuning for TimeoutTask in DefaultFuture #4129

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
25cda1b
Performance tuning for TimeoutTask in DefaultFuture, manually merge #…
chickenlj May 23, 2019
280d91c
use getFuture to avoid future being removed too early.
chickenlj May 23, 2019
85e91dc
check timeout
chickenlj May 23, 2019
02901f4
check future is not null
chickenlj May 23, 2019
957400b
check future is null
chickenlj May 23, 2019
cc170ae
change if condition from && to ||
chickenlj May 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions ...-remoting-api/src/main/java/org/apache/dubbo/remoting/exchange/support/DefaultFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,19 @@ public class DefaultFuture extends CompletableFuture<Object> {

private static final Map<Long, DefaultFuture> FUTURES = new ConcurrentHashMap<>();

private static final Map<Long, Timeout> PENDING_TASKS = new ConcurrentHashMap<>();

public static final Timer TIME_OUT_TIMER = new HashedWheelTimer(
new NamedThreadFactory("dubbo-future-timeout", true),
30,
TimeUnit.MILLISECONDS);

// invoke id.
private final long id;
private final Long id;
private final Channel channel;
private final Request request;
private final int timeout;
private final long start = System.currentTimeMillis();
private volatile long sent;
private Timeout timeoutCheckTask;

private DefaultFuture(Channel channel, Request request, int timeout) {
this.channel = channel;
Expand All @@ -79,9 +78,8 @@ private DefaultFuture(Channel channel, Request request, int timeout) {
* check time out of the future
*/
private static void timeoutCheck(DefaultFuture future) {
TimeoutCheckTask task = new TimeoutCheckTask(future);
Timeout t = TIME_OUT_TIMER.newTimeout(task, future.getTimeout(), TimeUnit.MILLISECONDS);
PENDING_TASKS.put(future.getId(), t);
TimeoutCheckTask task = new TimeoutCheckTask(future.getId());
future.timeoutCheckTask = TIME_OUT_TIMER.newTimeout(task, future.getTimeout(), TimeUnit.MILLISECONDS);
}

/**
Expand Down Expand Up @@ -140,15 +138,19 @@ public static void closeChannel(Channel channel) {
}

public static void received(Channel channel, Response response) {
received(channel, response, false);
}

public static void received(Channel channel, Response response, boolean timeout) {
try {
DefaultFuture future = FUTURES.remove(response.getId());
if (future != null) {
future.doReceived(response);
Timeout t = PENDING_TASKS.remove(future.getId());
if (t != null) {
Timeout t = future.timeoutCheckTask;
if (!timeout) {
// decrease Time
t.cancel();
}
future.doReceived(response);
} else {
logger.warn("The timeout response finally returned at "
+ (new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS").format(new Date()))
Expand Down Expand Up @@ -229,14 +231,15 @@ private String getTimeoutMessage(boolean scan) {

private static class TimeoutCheckTask implements TimerTask {

private DefaultFuture future;
private final Long requestID;

TimeoutCheckTask(DefaultFuture future) {
this.future = future;
TimeoutCheckTask(Long requestID) {
this.requestID = requestID;
}

@Override
public void run(Timeout timeout) {
DefaultFuture future = DefaultFuture.getFuture(requestID);
if (future == null || future.isDone()) {
return;
}
Expand All @@ -246,7 +249,7 @@ public void run(Timeout timeout) {
timeoutResponse.setStatus(future.isSent() ? Response.SERVER_TIMEOUT : Response.CLIENT_TIMEOUT);
timeoutResponse.setErrorMessage(future.getTimeoutMessage(true));
// handle response.
DefaultFuture.received(future.getChannel(), timeoutResponse);
DefaultFuture.received(future.getChannel(), timeoutResponse, true);

}
}
Expand Down