Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile iss #4155

Merged
merged 24 commits into from
May 24, 2019
Merged

Compile iss #4155

merged 24 commits into from
May 24, 2019

Conversation

cvictory
Copy link
Contributor

What is the purpose of the change

fix compile issue.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

…boMetadataReportRetryTimer in MetadataReportRetry
@htynkn htynkn mentioned this pull request May 24, 2019
6 tasks
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit c14605e into apache:master May 24, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4c01c5e). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4155   +/-   ##
=========================================
  Coverage          ?   62.29%           
  Complexity        ?      505           
=========================================
  Files             ?      789           
  Lines             ?    34911           
  Branches          ?     5461           
=========================================
  Hits              ?    21749           
  Misses            ?    10653           
  Partials          ?     2509
Impacted Files Coverage Δ Complexity Δ
...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java 48.31% <66.66%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c01c5e...3672ee3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants