-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve compile problem in java11 #4172
Solve compile problem in java11 #4172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4172 +/- ##
============================================
+ Coverage 62.78% 62.88% +0.09%
- Complexity 503 504 +1
============================================
Files 768 768
Lines 33020 33020
Branches 5192 5192
============================================
+ Hits 20733 20763 +30
+ Misses 9887 9856 -31
- Partials 2400 2401 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ignore the unit test because it is happened occasionally |
What is the purpose of the change
add javax-annotation dependency
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.