Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve compile problem in java11 #4172

Merged
merged 6 commits into from
May 27, 2019

Conversation

chickenlj
Copy link
Contributor

What is the purpose of the change

add javax-annotation dependency

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4172 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4172      +/-   ##
============================================
+ Coverage     62.78%   62.88%   +0.09%     
- Complexity      503      504       +1     
============================================
  Files           768      768              
  Lines         33020    33020              
  Branches       5192     5192              
============================================
+ Hits          20733    20763      +30     
+ Misses         9887     9856      -31     
- Partials       2400     2401       +1
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/remoting/transport/netty/NettyChannel.java 57.64% <0%> (-4.71%) 20% <0%> (-1%)
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0%> (-2.18%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 47.91% <0%> (-1.05%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 67.21% <0%> (+2.45%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 81.6% <0%> (+3.06%) 0% <0%> (ø) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.21% <0%> (+3.57%) 9% <0%> (+1%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 65.88% <0%> (+4.7%) 0% <0%> (ø) ⬇️
.../org/apache/dubbo/remoting/ExecutionException.java 21.05% <0%> (+5.26%) 0% <0%> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 78.94% <0%> (+5.26%) 0% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9559c4e...bcdf223. Read the comment docs.

Copy link
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvictory cvictory merged commit 18eb69e into apache:master May 27, 2019
@cvictory
Copy link
Contributor

Ignore the unit test because it is happened occasionally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants