-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for #4175: ServiceConfigurationListener should override ProviderConfigurationListener #4179
Conversation
…ConfigurationListener
…onfigurationListener
Codecov Report
@@ Coverage Diff @@
## master #4179 +/- ##
============================================
- Coverage 62.91% 62.85% -0.07%
+ Complexity 508 506 -2
============================================
Files 768 768
Lines 33059 33059
Branches 5218 5218
============================================
- Hits 20800 20780 -20
- Misses 9867 9884 +17
- Partials 2392 2395 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to add this comment, service > application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
fix for #4175: ServiceConfigurationListener should override ProviderConfigurationListener
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.