Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary null check before instance of #4321

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

slievrly
Copy link
Member

Signed-off-by: jimin.jm [email protected]

What is the purpose of the change

remove unnecessary null check before instance of

Brief changelog

remove unnecessary null check before instance of

Verifying this change

ci

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed due to unused imports

@kezhenxu94 kezhenxu94 requested review from kezhenxu94 and removed request for kezhenxu94 June 16, 2019 07:11
@slievrly
Copy link
Member Author

CI failed due to unused imports

Not related to unused import, if it is import problem, various jdk versions will have problems.

image

@kezhenxu94
Copy link
Member

CI failed due to unused imports

Not related to unused import, if it is import problem, various jdk versions will have problems.

image

I've re-triggered the job, wait for the result

@codecov-io
Copy link

Codecov Report

Merging #4321 into master will decrease coverage by 0.06%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4321      +/-   ##
============================================
- Coverage     62.93%   62.86%   -0.07%     
+ Complexity      506      504       -2     
============================================
  Files           769      769              
  Lines         32995    32995              
  Branches       5215     5215              
============================================
- Hits          20765    20742      -23     
- Misses         9831     9850      +19     
- Partials       2399     2403       +4
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 79.31% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/registry/support/ProviderInvokerWrapper.java 47.82% <0%> (ø) 0 <0> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyHelper.java 35.48% <100%> (+3.22%) 2 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-5.72%) 0% <0%> (ø)
...ng/exchange/support/header/HeartbeatTimerTask.java 73.68% <0%> (-5.27%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.54% <0%> (-2.69%) 0% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3a05c...1020bc9. Read the comment docs.

Copy link

@Moriadry-zz Moriadry-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Moriadry-zz
Copy link

How can i figure out all this kind of code has been modified correctly?

@slievrly
Copy link
Member Author

How can i figure out all this kind of code has been modified correctly?

Search for instance of+ code style plugin

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 81e61cc into apache:master Jun 19, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants