-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary null check before instance of #4321
Conversation
Signed-off-by: jimin.jm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failed due to unused imports
Codecov Report
@@ Coverage Diff @@
## master #4321 +/- ##
============================================
- Coverage 62.93% 62.86% -0.07%
+ Complexity 506 504 -2
============================================
Files 769 769
Lines 32995 32995
Branches 5215 5215
============================================
- Hits 20765 20742 -23
- Misses 9831 9850 +19
- Partials 2399 2403 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How can i figure out all this kind of code has been modified correctly? |
Search for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: jimin.jm <[email protected]>
Signed-off-by: jimin.jm <[email protected]>
Signed-off-by: jimin.jm [email protected]
What is the purpose of the change
remove unnecessary null check before instance of
Brief changelog
remove unnecessary null check before instance of
Verifying this change
ci
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.