-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-4355] Fix dubbo.jar do not contain "serialization-protobuf-json" module issue #4356
[Dubbo-4355] Fix dubbo.jar do not contain "serialization-protobuf-json" module issue #4356
Conversation
LGTM, CI running now. will merge after CI pass. Close #4355 |
Codecov Report
@@ Coverage Diff @@
## 2.7.3-release #4356 +/- ##
===================================================
- Coverage 62.97% 62.88% -0.09%
+ Complexity 505 503 -2
===================================================
Files 769 769
Lines 32995 32995
Branches 5215 5215
===================================================
- Hits 20777 20749 -28
- Misses 9822 9842 +20
- Partials 2396 2404 +8
Continue to review full report at Codecov.
|
hey @vio-lin , I have to say sorry for this mistake. First this PR should include in 2.7.3 release and thanks very much for your contribution. F So yesterday after I check this PR and click merge button in github, I notice this PR is for release branch, instead of master. I try to cherry-pick your commit to master and push it, but because of the configuration for repo, changes to master must be reviewed so I can't push directly. then I create another PR #4364 to merge it to master. And for release branch, I revert it because changes should review and pick up when release process officially start. And I mentioned above, this change will include in 2.7.3 and I already added milestone label yesterday. Thanks again for your contribution and sorry for this merge issue that changed commit information. |
Hi htynkn , |
…n" module issue (apache#4356) (apache#4364) * include protobuf-json jar to dubbo
…n" module issue (apache#4356) (apache#4364) * include protobuf-json jar to dubbo
…n" module issue (apache#4356) (apache#4364) * include protobuf-json jar to dubbo
fix issue #4355
What is the purpose of the change
the value of include node in dubbo-all/pom.xml is different from value in module
org.apache.dubbo dubbo-serialization-protobuf-json compile trueorg.apache.dubbo:dubbo-serialization-protobuf-json
Brief changelog
change one node value in dubbo-all/pom.xml
Verifying this change
change one node value in dubbo-all/pom.xml
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.