Dubbo 2.6.x cannot found correct method with telnet command #4611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment
Dubbo version: 2.6.6
Operating System version: *nix
Java version: 1.7
When we use complex arguments, in telnet mode , we need use jsonArray to parse.
But in our code ,someone try to resolve an overwrite problem ,so make an issue #257
then @beiwei30 try to fix this issue use this code below 27917f2
The code will make the default method not take effect.
The code before like this
We can have a default method with the the methodName and the same length arguments.
But after the code change , it must provides the correct arguments type. We should know
json parse cannot give the corrent type. It maybe JsonObject or even HashMap.
So someone points out this problem #2766.
In my opinion ,we should not define the same name method. Such as retry or timeout , these configs may just take effect in method or service or provider .In these cases ,methodName can stands for method. That is to say ,a lot of configs just consider the method name .
In dubbo 2.7.x, for this issue ,dubbo provides a new telnet command called select.
So ,We should consider which is better.
See issue #4565