Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svg): svg doesn't support addHover; fix #11054 #11156

Merged
merged 4 commits into from
Sep 3, 2019
Merged

fix(svg): svg doesn't support addHover; fix #11054 #11156

merged 4 commits into from
Sep 3, 2019

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Sep 3, 2019

fix #11054

src/util/graphic.js Outdated Show resolved Hide resolved
@pissang
Copy link
Contributor

pissang commented Sep 3, 2019

Agree with @100pah

You can try ignore useHoverLayer flag when using SVG render and fallback to normal highlight approach, which will change the style of the original element.

It's more correct than return and do nothing .

This solution also has are some disadvantages, for example it will cause refresh and maybe block the user interaction when there are many elements. But I think developers should not use so much elements when using SVG renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Found in test: lines-stream-not-large.html] addHover not implemented with SVG
3 participants