Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support expansion animation for data update; fix #11029 #11181

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Sep 6, 2019

fix #11029

Using a new option series-pie.animationTypeUpdate to support expansion animation for data update, whose value can be 'transition' (default), or 'expansion'.
If it's set to be 'transition', then the animation will be transforming from the previous data to the updated data, as it behaves with ECharts now.
If it's set to be 'expansion', then the animation works like when a pie is created for the first time, which may be useful when the data is fully changed.

@pissang
Copy link
Contributor

pissang commented Sep 6, 2019

LGTM.

Just another question about this improvement. Do we need support 'scale' for animationTypeUpdate?

@Ovilia
Copy link
Contributor Author

Ovilia commented Sep 6, 2019

Maybe after someone has such a requirement?

@Ovilia
Copy link
Contributor Author

Ovilia commented Sep 6, 2019

Document change: apache/echarts-doc#65

@Ovilia Ovilia merged commit 55de79f into master Sep 6, 2019
@Ovilia Ovilia deleted the fix-11029 branch September 6, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Pie expansion animation behavior
2 participants