fix(polar): angleAxis extent when boundaryGap is false #20184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
Ovilia
commented
Jul 22, 2024
| @@ -102,9 +102,15 @@ function updatePolarScale(this: Polar, ecModel: GlobalModel, api: ExtensionAPI) | |||
| // Fix extent of category angle axis | |||
| if (angleAxis.type === 'category' && !angleAxis.onBand) { | |||
| const extent = angleAxis.getExtent(); | |||
| const diff = 360 / (angleAxis.scale as OrdinalScale).count(); | |||
There was a problem hiding this comment.
We can see that the old code takes 360 as the range of endAngle to startAngle, which is not always the case.
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20184@c36098a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
When angleAxis in the polar system has
boundaryGap: false, the extent is adjusted since this commit so that polar bars don't overlap each other. The main idea is to make extra space according to data count. But it may overkill in some situations.Fixed issues
NA.
This PR is not a fix to #20172 , which is not a bug.
Details
Before: What was the problem?
Consider the case when
startAngle: 90, endAngle: -90, before this PR, it has the result of:This is not as expected because a developer set
startAngle: 90, endAngle: -90would expect the range to be half a circle.After: How does it behave after the fixing?
The extent of angleAxis with
boundaryGap: falseshould only be adjusted if it has the potential to overlap, that is to say,startAngle: 90, endAngle: -90should still get half a circle:while
startAngle: 90, endAngle: -270should get 3/4 of a circle:Please also not that if the range of startAngle and endAngle itself is over 360 degrees, it won't adjust to be smaller than a circle because it is not expected to.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
I added a test case under
test/bar-polar-basic-radial.html.I've run with
npm run test:visualand it passes all but the above case.Others
Merging options
Other information