fix(boxplot) correctly handle series.encode with category axis #20324
+151
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: awaiting review
PR: doc unchanged
PR: first-time contributor
labels
|
Thanks for your contribution! |
jonoshearman
changed the title
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20324@bc5c888 |
Ovilia
requested changes
Sep 20, 2024
src/chart/helper/whiskerBoxCommon.ts
Outdated
| */ | ||
| _hasEncodeRule(key: string) { | ||
| const encodeRules = this.getEncode(); | ||
| if(encodeRules?.data?.has(key)) |
There was a problem hiding this comment.
We avoid using ?. under compatible considerations. Please use encodeRules && encodeRules.data && encodeRules.data.has(key) instead.
There was a problem hiding this comment.
Thanks for the review @Ovilia
Changes pushed.
jonoshearman
force-pushed
the
fix-boxplot-category-encode-20319
branch
from
bc5c888
to
41ff0b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes issue with series.encode for boxplot when category axis is used.
Fixed issues
#20319
Details
Before: What was the problem?
When a category axis is used for a boxplot series, an ordinalValue is always inserted to the series.data which breaks any encoding rules. if the category axis does not set it's own data then the axis labels will be the integer ordinalValue.
After: How does it behave after the fixing?
Now if an encode rule is applied for the associated axis (x/y) then the ordinalValue is not inserted and the encoding rules work as expected.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
test/boxplot-category.html added to show visual example.
Others
Merging options
Other information