Skip to content

Commit

Permalink
comments addressed
Browse files Browse the repository at this point in the history
  • Loading branch information
whhe committed Jun 4, 2023
1 parent b49f10e commit 4ebdbb6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ public SourceFunction<T> build() {
&& (StringUtils.isNotEmpty(databaseName)
|| StringUtils.isNotEmpty(tableName))) {
throw new IllegalArgumentException(
"'database-name' and 'table-name' should be configured with 'INITIAL' mode");
"If startup mode is not 'INITIAL', 'database-name' and 'table-name' must not be configured");
}
if (StringUtils.isNotEmpty(databaseName) || StringUtils.isNotEmpty(tableName)) {
if (StringUtils.isEmpty(databaseName) || StringUtils.isEmpty(tableName)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,11 @@ private void initTableWhiteList() {
LOG.info("Pattern matched tables: {}", matchedTables);
localTableSet.addAll(matchedTables);
} catch (SQLException e) {
LOG.error("Query table list by 'databaseName' and 'tableName' failed", e);
LOG.error(
String.format(
"Query table list by 'database-name' %s and 'table-name' %s failed.",
databaseName, tableName),
e);
throw new FlinkRuntimeException(e);
}
}
Expand Down

0 comments on commit 4ebdbb6

Please sign in to comment.