[fix][cdc-base] Flink CDC base registers the identical history engine on multiple tasks #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyun2024
changed the title
molsionmo
reviewed
Jul 6, 2022
...ain/java/com/ververica/cdc/connectors/base/source/reader/external/JdbcSourceScanFetcher.java
Outdated
Show resolved
Hide resolved
...n/java/com/ververica/cdc/connectors/base/source/reader/external/JdbcSourceStreamFetcher.java
Outdated
Show resolved
Hide resolved
| if (source.schema().fields().stream().anyMatch(r -> SCHEMA_NAME_KEY.equals(r.name()))) { | ||
| return source.getString(SCHEMA_NAME_KEY); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
It is better to add a test for this method
There was a problem hiding this comment.
I also think we only need changes in this class and add some tests for it. Other changes need to be removed from this PR.
...t/java/com/ververica/cdc/connectors/base/experimental/fetch/MySqlSourceFetchTaskContext.java
Outdated
Show resolved
Hide resolved
...ava/com/ververica/cdc/connectors/base/source/reader/external/JdbcSourceFetchTaskContext.java
Outdated
Show resolved
Hide resolved
...-base/src/test/java/com/ververica/cdc/connectors/base/MySqlChangeEventSourceExampleTest.java
Outdated
Show resolved
Hide resolved
|
Thanks @fuyun2024 for the contribution, could you help rebase this PR to latest master? |
fuyun2024
force-pushed
the
cdc-base-1130
branch
from
9ba9235
to
cd610f4
Compare
fuyun2024
force-pushed
the
cdc-base-1130
branch
from
93c656f
to
7281781
Compare
leonardBang
approved these changes
Aug 2, 2022
There was a problem hiding this comment.
Thanks @fuyun2024 for the contribution, thanks @molsionmo and @molsionmo for the review work, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues : issues-1130