Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Db2 cdc connector (cp from #450) #1626

Closed
wants to merge 5 commits into from

Conversation

ruanhang1993
Copy link
Contributor

Support Db2 cdc connector , cherry pick from #450 .

@leonardBang
Copy link
Contributor

Thanks @ruanhang1993 for picking up the hanging task, @GOODBOY008 Would you like to take a look this PR?

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanhang1993 Thanks for your contributions. Should add e2e test and metadata columns support.

}

@Test
public void testConsumingAllEvents()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add timezone unit test.

Copy link
Contributor Author

@ruanhang1993 ruanhang1993 Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the time zone information for the timestamp types will not be contained in the debezium db2 connector. IMO this time zone setting may be useless.

docs/content/connectors/db2-cdc.md Show resolved Hide resolved
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruanhang1993 LGTM , @leonardBang Pls cc.

@GOODBOY008
Copy link
Member

@ruanhang1993 DB2 unit test is not runned , you can modify file in directory tools/azure-pipelines and tools/ci.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 and @GOODBOY008 for the great work. LGTM, I've checked the tutorial it works well.

leonardBang pushed a commit that referenced this pull request Oct 31, 2022
@leonardBang
Copy link
Contributor

leonardBang commented Oct 31, 2022

Implemented in 3592dcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants