Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdc-base] JdbcSourceConfig can be template type of DataSourceDialect #1639

Merged
merged 1 commit into from
Oct 20, 2022
Merged

[cdc-base] JdbcSourceConfig can be template type of DataSourceDialect #1639

merged 1 commit into from
Oct 20, 2022

Conversation

Jiabao-Sun
Copy link
Contributor

JdbcSourceConfig can be template type of DataSourceDialect.

GOODBOY008
GOODBOY008 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiabao-Sun LGTM, Thanks for your contributions.

@GOODBOY008 GOODBOY008 merged commit ddd0680 into apache:master Oct 20, 2022
@Jiabao-Sun Jiabao-Sun deleted the fix-source-config-template-type branch December 27, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiabao-Sun @GOODBOY008