-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Support print options for flink cdc sql connectors #2099
Conversation
Hi @GOODBOY008 , in this task I have changed the following things:
So I add a same class into module, for this problem do you have any good advice? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TyrantLucifer Thanks for your contribution. I left some comments.
flink-cdc-base/src/main/java/com/ververica/cdc/connectors/base/utils/OptionUtils.java
Outdated
Show resolved
Hide resolved
flink-cdc-base/src/test/java/com/ververica/cdc/connectors/base/utils/OptionUtilsTest.java
Outdated
Show resolved
Hide resolved
...ctor-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/table/Db2TableSourceFactory.java
Outdated
Show resolved
Hide resolved
5deea99
to
96597fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe each module invoke the base module is not a good idea. Serval connectors should not rely on the base module before they are moved to the new incremental snapshot framework.
I think we should introduce separate OptionUtils for them.
flink-cdc-base/src/main/java/com/ververica/cdc/connectors/base/utils/OptionUtils.java
Outdated
Show resolved
Hide resolved
flink-connector-db2-cdc/src/main/java/com/ververica/cdc/connectors/db2/utils/OptionUtils.java
Show resolved
Hide resolved
3692ebb
to
b6884ff
Compare
4f01866
to
1bc8651
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
commit 7ced72b6426e9723f91933ef0144fdda4b9c072d Author: Hang Ruan <[email protected]> Date: Thu Jun 8 17:01:39 2023 +0800 [mysql-cdc] Supports MYSQL_TYPE_TYPED_ARRAY column type when parsing the table map event This closes apache#2001 commit a847655ed68c4d5874ced69006686362f23140e7 Author: Leonard Xu <[email protected]> Date: Thu Jun 8 15:33:54 2023 +0800 [mysql-cdc][hotfix] Optimize the error msg when binlog expire in source commit 32f77ef0075dfd2b522df07809ab2aea8ae6de54 Author: Leonard Xu <[email protected]> Date: Wed Jun 7 17:49:41 2023 +0800 [mysql-cdc] Optimize the error msg when binlog expire or server id conflict This closes apache#2010. commit da5cbf54e6b219956088bb99cec44d93f1011ff7 Author: He Wang <[email protected]> Date: Thu Jun 8 13:50:24 2023 +0800 [oceanbase] add jdbc options and support oracle mode (apache#1854) commit 0e221382601e352215091d9cd1cb59fa2175063b Author: Leonard Xu <[email protected]> Date: Wed Jun 7 17:34:57 2023 +0800 [mysql-cdc] Add handler for catching async exceptions in snapshot reading executor This closes apache#2016. commit 15e5e4d34dc05edcbdcfe15ff906213352a2cd02 Author: Hang Ruan <[email protected]> Date: Wed Jun 7 17:26:59 2023 +0800 [hotfix][mysql-cdc] Use session timezone instead of local time zone as the default server time zone This closes apache#2015. commit 13235e2f2dca73320988a430b765f1fafa8e8f26 Author: Hang Ruan <[email protected]> Date: Wed Jun 7 17:22:07 2023 +0800 [mysql] Fix NullPointerException when database name or table name contains dot This closes apache#2006. commit 6aa0fc4de353473cb7cda844a432e3dd5ddf4fea Author: Hang Ruan <[email protected]> Date: Thu Jan 12 02:18:52 2023 +0000 [mysql] Fix NullPointerException caused by mysql ignores the capitalization when splitting chunks commit e9fed740f55f7f1e675e5fe83f7e04efb5e3f866 Author: ehui <[email protected]> Date: Tue Jun 6 13:06:03 2023 +0800 [sqlserver] Fix old change data that will be captured when the latest mode starts (apache#2176) commit d2ffa0902038e9aec0e2b92fa4e82a066d1b123f Author: Tyrantlucifer <[email protected]> Date: Mon Jun 5 23:15:33 2023 +0800 [core] support print configuration options for connectors (apache#2099) commit a00abf88178feb6a2c699129e1f6aefb005960c7 Author: He Wang <[email protected]> Date: Mon Jun 5 16:40:54 2023 +0800 [oceanbase] support libobcdc 4.x and fix restore timestamp config (apache#2161) commit 061602d Author: ehui <[email protected]> Date: Mon Jun 5 23:49:15 2023 +0800 oralce commit 8dc46cc Author: ehui <[email protected]> Date: Mon Jun 5 00:18:50 2023 +0800 [oracle]
close #1742